Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14846 )
Change subject: IMPALA-9195: Using multithreaded execution to accelerate 'show tables/databases' ...................................................................... Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/14846/11/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14846/11/fe/src/main/java/org/apache/impala/service/Frontend.java@857 PS11, Line 857: LOG.error("Encountered an error checking access", e); > Continuing the loop when it comes into an exception can help get all the ex I think they are probably the same kind of exception so don't need to log them all. Most importantly, before this patch, we stop when the first exception is thrown. After this patch, we have to iterate all the candidates and wait until they all fail, which could take time if the exception is some sort of connection timeout errors. I think we should act as the current behavior. Thoughts? -- To view, visit http://gerrit.cloudera.org:8080/14846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I860e0d18afa0421665f8b3b1c5561d6bdacc5e96 Gerrit-Change-Number: 14846 Gerrit-PatchSet: 14 Gerrit-Owner: Zhou Xu <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zhou Xu <[email protected]> Gerrit-Comment-Date: Wed, 25 Dec 2019 13:30:11 +0000 Gerrit-HasComments: Yes
