wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/14962 )
Change subject: IMPALA-9266: Use custom cluster test case to replace CreateKuduTableWithoutHMSTest.java ...................................................................... Patch Set 8: (7 comments) http://gerrit.cloudera.org:8080/#/c/14962/5/bin/create-test-configuration.sh File bin/create-test-configuration.sh: http://gerrit.cloudera.org:8080/#/c/14962/5/bin/create-test-configuration.sh@143 PS5, Line 143: export HIVE_VARIANT=changed_external_dir : $IMPALA_HOME/bin/generate_xml_config.py hive-site.xml.py hive-site_ext.xml : mk > The config should be generated each time we run bin/create-test-configurati Done http://gerrit.cloudera.org:8080/#/c/14962/5/tests/custom_cluster/test_kudu_table_create_without_hms.py File tests/custom_cluster/test_kudu_table_create_without_hms.py: http://gerrit.cloudera.org:8080/#/c/14962/5/tests/custom_cluster/test_kudu_table_create_without_hms.py@25 PS5, Line 25: TBL_NAME = "test_kudu_table_create_without_hms" > Please use another dir. 'hive-site-ext' is used for hive-site.xml with non- Done http://gerrit.cloudera.org:8080/#/c/14962/5/tests/custom_cluster/test_kudu_table_create_without_hms.py@29 PS5, Line 29: est creating kudu managed tab > nit: TestCreatingKuduTableWithoutHMS is more correct in grammar. Done http://gerrit.cloudera.org:8080/#/c/14962/5/tests/custom_cluster/test_kudu_table_create_without_hms.py@35 PS5, Line 35: self.execute_query_expect_success(self.client, "create table %s " > We should not run bin/create-test-configuration.sh everytime we run this te Done http://gerrit.cloudera.org:8080/#/c/14962/5/tests/custom_cluster/test_kudu_table_create_without_hms.py@42 PS5, Line 42: : : : : > Don't need to create the client like this. This is a single thread test. Yo Done http://gerrit.cloudera.org:8080/#/c/14962/5/tests/custom_cluster/test_kudu_table_create_without_hms.py@48 PS5, Line 48: : > We should create the table in a unique database. Just declare the function Done http://gerrit.cloudera.org:8080/#/c/14962/5/tests/custom_cluster/test_kudu_table_create_without_hms.py@56 PS5, Line 56: > Same here. Don't need teardown. Done -- To view, visit http://gerrit.cloudera.org:8080/14962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic532574af42ed864612cf28eecee9e0416ef272c Gerrit-Change-Number: 14962 Gerrit-PatchSet: 8 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Thu, 02 Jan 2020 01:54:33 +0000 Gerrit-HasComments: Yes
