Thomas Tauber-Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14985 )

Change subject: IMPALA-9262: De-flake 
TestBlacklist::test_kill_impalad_with_running_queries
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14985/1/tests/custom_cluster/test_blacklist.py
File tests/custom_cluster/test_blacklist.py:

http://gerrit.cloudera.org:8080/#/c/14985/1/tests/custom_cluster/test_blacklist.py@129
PS1, Line 129:         'debug_action': '0:GETNEXT:DELAY|1:GETNEXT:DELAY'})
If I understand correctly, this will just add 200ms or so to execution time, so 
the test still relies on timing and could be flaky still? Is it possible to use 
the WAIT debug action, which will cause the query to basically hang until 
cancelled?



--
To view, visit http://gerrit.cloudera.org:8080/14985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8129323a7eb62cef61f1c6c34da06f08cf6d4b06
Gerrit-Change-Number: 14985
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Comment-Date: Wed, 08 Jan 2020 21:51:20 +0000
Gerrit-HasComments: Yes

Reply via email to