Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14992 )
Change subject: WIP: Testing python2/python3 backwards compatibility or impala-shell ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/14992/2/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/14992/2/shell/impala_shell.py@22 PS2, Line 22: import pdb flake8: F401 'pdb' imported but unused http://gerrit.cloudera.org:8080/#/c/14992/2/shell/impala_shell.py@40 PS2, Line 40: def pass_set_trace(): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/14992/2/shell/impala_shell.py@129 PS2, Line 129: class ImpalaShell(cmd.Cmd, object): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/14992/2/shell/impala_shell.py@355 PS2, Line 355: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/14992/2/shell/impala_shell.py@865 PS2, Line 865: e flake8: F841 local variable 'e' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/14992/2/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/14992/2/shell/shell_output.py@19 PS2, Line 19: import pdb flake8: F401 'pdb' imported but unused -- To view, visit http://gerrit.cloudera.org:8080/14992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a61b5d48e8a83463bab925237d7b90b8bb69e7 Gerrit-Change-Number: 14992 Gerrit-PatchSet: 2 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 09 Jan 2020 00:06:57 +0000 Gerrit-HasComments: Yes
