Attila Jeges has posted comments on this change. (
http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp. This change
will help with queries generated by some BI tools. Case 1: Simplify 'string ->
bigint -> timestamp' TO 'string -> timestamp': cast(unix_timestamp('timestr')
as timestamp) -> cast('timestr' as
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14896/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14896/4//COMMIT_MSG@8
PS4, Line 8: This change will help with queries generated by some BI tools.
: Case 1:
: Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp':
: cast(unix_timestamp('timestr') as timestamp) -> cast('timestr' as
timestamp)
: Case 2:
: Simplify 'string[fmt] -> bigint -> timestamp' TO 'string ->
timestamp':
: cast(unix_timestamp('timestr', 'fmt') as timestamp) ->
to_timestamp('timestr', 'fmt')
Also, please wrap long lines at 70 characters.
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 4
Gerrit-Owner: Zhou Xu <[email protected]>
Gerrit-Reviewer: Attila Jeges <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zhou Xu <[email protected]>
Gerrit-Comment-Date: Thu, 09 Jan 2020 10:38:44 +0000
Gerrit-HasComments: Yes
