Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14867 )
Change subject: IMPALA-9222: Speed up show tables/DBs if the user has access to parent db/server ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/14867/10/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14867/10/fe/src/main/java/org/apache/impala/service/Frontend.java@1029 PS10, Line 1029: getAuthorizationConfig(). missed changing this to getProviderName()? http://gerrit.cloudera.org:8080/#/c/14867/10/fe/src/main/java/org/apache/impala/service/Frontend.java@1084 PS10, Line 1084: userHasServerLevelAccess do you think we should have preconditions in this method and in userHasDbLevelAccess method to confirm that its Sentry and not Ranger? -- To view, visit http://gerrit.cloudera.org:8080/14867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f5c5d1cf447a9f1cec46c45272f250b8580826 Gerrit-Change-Number: 14867 Gerrit-PatchSet: 10 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Fri, 10 Jan 2020 02:05:32 +0000 Gerrit-HasComments: Yes
