Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14799 )
Change subject: IMPALA-9101: Add support for detecting self-events on partition events ...................................................................... Patch Set 7: Code-Review+2 (3 comments) Thanks for addressing the comments! Carry on Anurag's +1. http://gerrit.cloudera.org:8080/#/c/14799/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/14799/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2265 PS7, Line 2265: table == null || nit: don't need it. already checked above http://gerrit.cloudera.org:8080/#/c/14799/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/14799/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4307 PS5, Line 4307: commitTransaction(update.getTransaction_id()); > Unfortunately, adding the catalog version for inserted table and partitions Thanks for the explanation! http://gerrit.cloudera.org:8080/#/c/14799/7/tests/custom_cluster/test_event_processing.py File tests/custom_cluster/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/14799/7/tests/custom_cluster/test_event_processing.py@245 PS7, Line 245: [ > flake8: E131 continuation line unaligned for hanging indent nit: Not sure if moving the "[" above to be right after "True: " cound fix this. https://www.flake8rules.com/rules/E131.html -- To view, visit http://gerrit.cloudera.org:8080/14799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b4148f6be0f9f946c8ad8f314d64b095731744c Gerrit-Change-Number: 14799 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Fri, 10 Jan 2020 06:53:52 +0000 Gerrit-HasComments: Yes
