Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15021 )
Change subject: WIP IMPALA-9249: Fix ORC scanner crash when root type is not struct ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Looks good to me. Let's ship this quick fix! http://gerrit.cloudera.org:8080/#/c/15021/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15021/2//COMMIT_MSG@14 PS2, Line 14: TODO: no test yet, as I couldn't reproduce the crash until now Sorry for not uploading a corrupt file in the JIRA. But I think we can skip test since it's trivial. Can also avoid adding a new file into our already large code base. http://gerrit.cloudera.org:8080/#/c/15021/2/be/src/exec/orc-metadata-utils.cc File be/src/exec/orc-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/15021/2/be/src/exec/orc-metadata-utils.cc@28 PS2, Line 28: node nit: type? -- To view, visit http://gerrit.cloudera.org:8080/15021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b Gerrit-Change-Number: 15021 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 14 Jan 2020 13:59:05 +0000 Gerrit-HasComments: Yes
