Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15021 )
Change subject: IMPALA-9249: Fix ORC scanner crash when root type is not struct ...................................................................... IMPALA-9249: Fix ORC scanner crash when root type is not struct The root type should be struct as far as I know, and this was checked with a DCHECK, leading to crashes in fuzz tests. This change replaced the DCHECK with returning an error message. Testing: - added corrupt ORC file and e2e test Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b Reviewed-on: http://gerrit.cloudera.org:8080/15021 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/hdfs-orc-scanner.cc M be/src/exec/orc-metadata-utils.cc M be/src/exec/orc-metadata-utils.h M testdata/data/README A testdata/data/corrupt_root_type.orc M tests/query_test/test_scanners.py 6 files changed, 40 insertions(+), 24 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7fba8cffbcdf8f647e27e2d5ee9e6716a4492b9b Gerrit-Change-Number: 15021 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
