Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14975 )
Change subject: IMPALA-9154: Make runtime filter propagation asynchronous ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14975/4/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/14975/4/be/src/runtime/coordinator.cc@1139 PS4, Line 1139: DCHECK(it != filter_routing_table_->id_to_filter.end()); > So I know that in a previous iteration of this patch, I told you to change Also, fwiw, another option is to have both the 'if' and the DCHECK - that way we're likely to notice if this is hit in a test run, since the DCHECK will cause a crash, and we're more likely to actually investigate and figure out if something went wrong, but we're still being defensive in production deployments. -- To view, visit http://gerrit.cloudera.org:8080/14975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb6726d349be701f3a0602b2ad5a934082f188a0 Gerrit-Change-Number: 14975 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 14 Jan 2020 19:22:57 +0000 Gerrit-HasComments: Yes
