Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14927 )
Change subject: IMPALA-6393 live_summary and live_progress are not supported in impalarc ...................................................................... IMPALA-6393 live_summary and live_progress are not supported in impalarc The internal variables for live_summary and live_progress are defined as print_summary and print_progress in impala_shell. When reading configuration parameters from the config file, it save configurations as dictionary with external name as key. This cause live_summary and live_progress in impalarc do not take effect in impala_shell. To fix the issue, change internal variable names same as external names for option live_summary and live_progress. Unit test: 1) manually verified live_summary and live_progress are supported in impalarc 2) add some unit-test cases in test_shell_commandline.py and test_shell_interactive.py for option live_summary and live_progress read from impalarc. 3) passed all test cases for tests/shell/test_shell_interactive.py and tests/shell/test_shell_commandline.py Change-Id: If4549b775a7966ad89d661d0349cc78754e13a86 --- M bin/rat_exclude_files.txt M shell/impala_shell.py M shell/impala_shell_config_defaults.py M shell/option_parser.py A tests/shell/good_impalarc3 A tests/shell/good_impalarc4 A tests/shell/impalarc_with_error2 M tests/shell/test_shell_commandline.py M tests/shell/test_shell_interactive.py 9 files changed, 93 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/14927/3 -- To view, visit http://gerrit.cloudera.org:8080/14927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If4549b775a7966ad89d661d0349cc78754e13a86 Gerrit-Change-Number: 14927 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
