Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 )
Change subject: IMPALA-9010: Add builtin mask functions ...................................................................... Patch Set 11: (2 comments) The UBSAN test don't allow me to test on overflow behavior, which causes the GVO failure. So I removed the overflow tests. Also addressed Kurt's comments. http://gerrit.cloudera.org:8080/#/c/14963/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14963/10//COMMIT_MSG@63 PS10, Line 63: requires hundreds of overloads to cover all possible combinations. We > Also mention that we want the masking functions to be evaluated in the back Done http://gerrit.cloudera.org:8080/#/c/14963/10/be/src/exprs/mask-functions-ir.cc File be/src/exprs/mask-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/14963/10/be/src/exprs/mask-functions-ir.cc@44 PS10, Line 44: > Please reference the hive class that these were derived from in the comment Sure. -- To view, visit http://gerrit.cloudera.org:8080/14963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica779a1bf63a085d51f3b533f654cbaac102a664 Gerrit-Change-Number: 14963 Gerrit-PatchSet: 11 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2020 00:48:21 +0000 Gerrit-HasComments: Yes
