Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14944 )
Change subject: IMPALA-4224: part 1: schedule join builds ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/14944/2/be/src/scheduling/scheduler.h File be/src/scheduling/scheduler.h: http://gerrit.cloudera.org:8080/#/c/14944/2/be/src/scheduling/scheduler.h@403 PS2, Line 403: Therefore, those instances must have already been created : /// by the scheduler. > Did you mean that "this expects that the instances that consume the join bu Done http://gerrit.cloudera.org:8080/#/c/14944/2/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/14944/2/common/thrift/ImpalaInternalService.thrift@618 PS2, Line 618: that will consum > nit: that will consume the output of this join build Done http://gerrit.cloudera.org:8080/#/c/14944/2/common/thrift/ImpalaInternalService.thrift@621 PS2, Line 621: // Fragment instance id of the input fragment instance. > nit: input fragment instance Done http://gerrit.cloudera.org:8080/#/c/14944/2/fe/src/main/java/org/apache/impala/planner/JoinBuildSink.java File fe/src/main/java/org/apache/impala/planner/JoinBuildSink.java: http://gerrit.cloudera.org:8080/#/c/14944/2/fe/src/main/java/org/apache/impala/planner/JoinBuildSink.java@41 PS2, Line 41: // Reference to the join node that consumes the build side. > nit: maybe add a small one line comment like we have for joinTableId_ Done -- To view, visit http://gerrit.cloudera.org:8080/14944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I779463cfa2ea9b372607d2be6d5d2252a6469e34 Gerrit-Change-Number: 14944 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 17 Jan 2020 17:34:20 +0000 Gerrit-HasComments: Yes
