Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14917 )
Change subject: IMPALA-9197: make HashTable lookups thread-safe ...................................................................... IMPALA-9197: make HashTable lookups thread-safe This makes it possible to do HashTable lookups from multiple threads without any data races. This requires moving statistics that are updated during probing to the HashTableCtx object. There are some small changes to the hash table stat logging behaviour as a result of the stats being moved to the context. I don't believe these logs are used much, if at all. Testing: Ran exhaustive tests. Manually inspected some aggregation and join query profiles to check that hash table stats looked reasonable. Perf: Ran TPC-H scale factor 30 on a single node. No significant change in perf. Change-Id: I92fbfa8cc000477b8e01975a102d818f9fa27c61 Reviewed-on: http://gerrit.cloudera.org:8080/14917 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/grouping-aggregator.cc M be/src/exec/grouping-aggregator.h M be/src/exec/hash-table.cc M be/src/exec/hash-table.h M be/src/exec/hash-table.inline.h M be/src/exec/partitioned-hash-join-builder.cc M be/src/exec/partitioned-hash-join-builder.h M be/src/exec/partitioned-hash-join-node.cc 8 files changed, 136 insertions(+), 71 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I92fbfa8cc000477b8e01975a102d818f9fa27c61 Gerrit-Change-Number: 14917 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
