Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15051 )
Change subject: IMPALA-9226: Improve string allocations of the ORC scanner ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/15051/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15051/2//COMMIT_MSG@17 PS2, Line 17: aquired nit: acquired http://gerrit.cloudera.org:8080/#/c/15051/2//COMMIT_MSG@25 PS2, Line 25: col_name | encoding | before | after nit: you could add a 'speedup' column http://gerrit.cloudera.org:8080/#/c/15051/2//COMMIT_MSG@31 PS2, Line 31: 8 core Since you measured with MT_DOP and NUM_NUDES being 1, having 8 core is not significant here. http://gerrit.cloudera.org:8080/#/c/15051/2/be/src/exec/orc-column-readers.cc File be/src/exec/orc-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/15051/2/be/src/exec/orc-column-readers.cc@167 PS2, Line 167: nit: extra space http://gerrit.cloudera.org:8080/#/c/15051/2/be/src/exec/orc-column-readers.cc@175 PS2, Line 175: = nit: put the '=' sign to the previous line -- To view, visit http://gerrit.cloudera.org:8080/15051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2d975946fb6f4104d8dc98895285b3a0c6bef7f Gerrit-Change-Number: 15051 Gerrit-PatchSet: 2 Gerrit-Owner: Norbert Luksa <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 20 Jan 2020 14:04:50 +0000 Gerrit-HasComments: Yes
