Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14666 )
Change subject: IMPALA-8205: Support number of true and false statistics for boolean column ...................................................................... Patch Set 6: Code-Review+1 (2 comments) This patch looks good to me. Just have few nits. http://gerrit.cloudera.org:8080/#/c/14666/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14666/6//COMMIT_MSG@7 PS6, Line 7: nit: only need one space here http://gerrit.cloudera.org:8080/#/c/14666/6/be/src/exec/incr-stats-util.cc File be/src/exec/incr-stats-util.cc: http://gerrit.cloudera.org:8080/#/c/14666/6/be/src/exec/incr-stats-util.cc@164 PS6, Line 164: DCHECK_GE(num_trues, 0); : DCHECK_GE(num_falses, 0); I think we should check the arguments instead. -- To view, visit http://gerrit.cloudera.org:8080/14666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I991bee8e7fdc644d908289f5fe2ee8032cc2c431 Gerrit-Change-Number: 14666 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 21 Jan 2020 03:54:37 +0000 Gerrit-HasComments: Yes
