Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15073 )
Change subject: IMPALA-6772: Add ORC 1.6.2 to toolchain ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15073/3/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/15073/3/buildall.sh@347 PS3, Line 347: export SNAPPY_VERSION=1.1.4 Shouldn't these versions get updated to match the ones in the ORC lib? https://github.com/apache/orc/blob/master/cmake_modules/ThirdpartyToolchain.cmake#L14 -- To view, visit http://gerrit.cloudera.org:8080/15073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62734f791fd8fc098579f488a869a2153ebad919 Gerrit-Change-Number: 15073 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 21 Jan 2020 14:29:06 +0000 Gerrit-HasComments: Yes
