Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15088 )
Change subject: IMPALA-9149: part 2: Re-enable Ranger-related EE tests ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Good job! LGTM. http://gerrit.cloudera.org:8080/#/c/15088/2/tests/authorization/test_authorized_proxy.py File tests/authorization/test_authorized_proxy.py: http://gerrit.cloudera.org:8080/#/c/15088/2/tests/authorization/test_authorized_proxy.py@119 PS2, Line 119: "non_owner" nit: As it's a constant now, we can put it in the string. The same in other places that change getuser() to "non_owner". http://gerrit.cloudera.org:8080/#/c/15088/2/tests/authorization/test_authorized_proxy.py@139 PS2, Line 139: --use_customized_user_group_mapper_for_ranger=true nit: Can the boolean type flag be used without "=true"? -- To view, visit http://gerrit.cloudera.org:8080/15088 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17420d7ff9beacd1b4d2ad72b68b8b54983e60cb Gerrit-Change-Number: 15088 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 22 Jan 2020 02:52:56 +0000 Gerrit-HasComments: Yes
