Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15053 )
Change subject: IMPALA-4080 [part 1]: Move codegen code from aggregation exec nodes to their plan nodes ...................................................................... Patch Set 5: Code-Review+1 (1 comment) LGTM aside from one thing. I can upgrade to a +2 tomorrow, but wanted to give Csaba and Daniel another chance to look at it. http://gerrit.cloudera.org:8080/#/c/15053/5/be/src/exec/hash-table.h File be/src/exec/hash-table.h: http://gerrit.cloudera.org:8080/#/c/15053/5/be/src/exec/hash-table.h@114 PS5, Line 114: struct HashTableConfig { Can we make any more of these members const? It looks like they're mostly initialised by the constructor -- To view, visit http://gerrit.cloudera.org:8080/15053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58f52a262ac7d0af259d5bcda72ada93a851d3b2 Gerrit-Change-Number: 15053 Gerrit-PatchSet: 5 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 22 Jan 2020 23:24:27 +0000 Gerrit-HasComments: Yes
