Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/15072 )
Change subject: IMPALA-9265: Support for toolchain Kudu to provide Java artifacts ...................................................................... Patch Set 2: (3 comments) > (3 comments) > > I think the changes to the docker side make sense. I have a few > small comments, but it sounds good. > > For the actual kudu build steps, I think we'll need to see what > Impala needs from the Kudu java side to get this right. I left a > comment about what I think we would need, but I don't think our > progress needs to be blocked on everything being perfect. One way > forward is that we put the Kudu java artifacts in a subdirectory > (which we know will not conflict with the existing implementation) > and then it becomes fairly harmless to check in something that is > not perfect. Then, as we do the Impala change and find what we > need, we do an additional change to get anything we missed. Another > way forward is to merge the docker stuff (which lets us update the > docker images) and then do the Kudu part in concert with the Impala > change. Thanks for the help. I decided to generate the Java artifacts and put them into a subdirectory in this patch-set. I'll do a kudu version bump in a separate patch and finally change Impala to consume the generated Java artifacts in a third patch. http://gerrit.cloudera.org:8080/#/c/15072/2/docker/redhat6.df File docker/redhat6.df: http://gerrit.cloudera.org:8080/#/c/15072/2/docker/redhat6.df@15 PS2, Line 15: # Install a newer java-1.8.0-openjdk-devel from centos:6.8. : # The java-1.8.0-openjdk-devel version shipped with centos:6.6 is unable to handle ECDHE : # ciphers. : RUN yum-install --disablerepo='*' --enablerepo=C6.8-base java-1.8.0-openjdk-devel > The way I think about this is that there are some libraries we use newer ve Done http://gerrit.cloudera.org:8080/#/c/15072/2/docker/redhat7.df File docker/redhat7.df: http://gerrit.cloudera.org:8080/#/c/15072/2/docker/redhat7.df@9 PS2, Line 9: # We get a newer java-1.8.0-openjdk-devel from centos:7.4. : # The java-1.8.0-openjdk version shipped with centos:7.2 is unable to handle ECDHE : # ciphers. : RUN yum-install --disablerepo='*' --enablerepo=C7.4-base java-1.8.0-openjdk-devel > Same as the redhat6.df comment, move this below the big install command. Done http://gerrit.cloudera.org:8080/#/c/15072/2/source/kudu/build.sh File source/kudu/build.sh: http://gerrit.cloudera.org:8080/#/c/15072/2/source/kudu/build.sh@140 PS2, Line 140: wrap ./gradlew :kudu-hive:assemble : for F in kudu-hive/build/libs/kudu-*.jar; do : cp "$F" "$JAVA_INSTALL_DIR" : done > My thought on this part is that we are going to want to test it with the co I've changed the code to put the kudu-hive jars and the kudu-client maven repo to $LOCAL_INSTALL/java. Done. -- To view, visit http://gerrit.cloudera.org:8080/15072 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af Gerrit-Change-Number: 15072 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Sat, 25 Jan 2020 07:21:59 +0000 Gerrit-HasComments: Yes
