Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15103 )
Change subject: IMPALA-9324: Correctly handle ORC UNION type in scanner ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15103/5/be/src/exec/orc-metadata-utils.cc File be/src/exec/orc-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/15103/5/be/src/exec/orc-metadata-utils.cc@45 PS5, Line 45: "F > nit: too much indentation Done http://gerrit.cloudera.org:8080/#/c/15103/5/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/15103/5/tests/query_test/test_scanners.py@1337 PS5, Line 1337: self.run_test_case('DataErrorsTest/orc-type-checks', vector, unique_database) : : def test_orc_timestamp_out_of_range(self, vector, unique_database): : """Test the validation of out-of-range timestamps.""" : test_files = ["testdata/data/out_of_range_timestamp.orc"] : create_table_and_copy_files(self.client, "create table {db}.{tbl} " : "(ts timestamp) stored as orc", : unique_database, "out_of_range_timestamp", test_files) : new_vector = deepcopy(vector) > Can it be moved to orc-type-checks.test? Sure. Better to be there to have pretty format. -- To view, visit http://gerrit.cloudera.org:8080/15103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I452d27b4e281eada00b62ac58af773a3479163ec Gerrit-Change-Number: 15103 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 27 Jan 2020 15:56:29 +0000 Gerrit-HasComments: Yes
