Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15111 )
Change subject: IMPALA-8587: Show inherited privileges with Ranger show grant ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/15111/3/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/15111/3/tests/authorization/test_ranger.py@434 PS3, Line 434: nit: Can you change the indentation to +4 in the other _check_privileges calls too? http://gerrit.cloudera.org:8080/#/c/15111/3/tests/authorization/test_ranger.py@438 PS3, Line 438: Can you add another test that adds an ALL privilege, e.g. on table level, and checks whether it masks the other privileges? -- To view, visit http://gerrit.cloudera.org:8080/15111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4e679dc6fcf8d0b0e4e0fc2e9b335e2d8bc0899 Gerrit-Change-Number: 15111 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Austin Nobis <austinno...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 31 Jan 2020 13:20:59 +0000 Gerrit-HasComments: Yes
