Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 )
Change subject: IMPALA-9336: [DOCS] constraints ...................................................................... Patch Set 1: (5 comments) Thanks for making these changes to the docs. I have a few comments and nits. http://gerrit.cloudera.org:8080/#/c/15146/1/docs/topics/impala_create_table.xml File docs/topics/impala_create_table.xml: http://gerrit.cloudera.org:8080/#/c/15146/1/docs/topics/impala_create_table.xml@145 PS1, Line 145: Nit: I see a few places where there is extra indentation. In Gerrit, this is marked with red. Could you please remove these for consistency? http://gerrit.cloudera.org:8080/#/c/15146/1/docs/topics/impala_create_table.xml@147 PS1, Line 147: [DISABLE] [NOVALIDATE] [RELY] DISABLE NOVALIDATE RELY is not common to the entire PK/FK definition, it has to be mentioned in primary key spec as well as EACH foreign key spec. Maybe this will be more accurate?: constraint_specification: PRIMARY KEY (<varname>col_name</varname>, ...) [DISABLE] [NOVALIDATE] [RELY],[<varname>foreign_key_specification</varname>, ...] foreign_key_specification: FOREIGN KEY (<varname>col_name</varname>, ...) REFERENCES table_name(<varname>col_name</varname>, ...) [DISABLE] [NOVALIDATE] [RELY] http://gerrit.cloudera.org:8080/#/c/15146/1/docs/topics/impala_create_table.xml@150 PS1, Line 150: Nit: Extra indentation http://gerrit.cloudera.org:8080/#/c/15146/1/docs/topics/impala_create_table.xml@151 PS1, Line 151: Nit: Extra indentation http://gerrit.cloudera.org:8080/#/c/15146/1/docs/topics/impala_create_table.xml@291 PS1, Line 291: Nit: Extra indentation -- To view, visit http://gerrit.cloudera.org:8080/15146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820 Gerrit-Change-Number: 15146 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sun, 02 Feb 2020 02:35:41 +0000 Gerrit-HasComments: Yes
