Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15108 )
Change subject: IMPALA-9330: Support resolving unmasked nested columns ...................................................................... Patch Set 8: (5 comments) Thanks for your review! http://gerrit.cloudera.org:8080/#/c/15108/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15108/7//COMMIT_MSG@8 PS7, Line 8: > Please add that the patch deals with nested tables which have column masks Done http://gerrit.cloudera.org:8080/#/c/15108/7//COMMIT_MSG@14 PS7, Line 14: select t.id, a.item from tableA t, t.int_array a; > These seem like hacks to me (especailly 2.) that are needed because InlineV Done http://gerrit.cloudera.org:8080/#/c/15108/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/15108/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@912 PS7, Line 912: Resolves > Nit: Did you mean Resolves? Oops, yes... http://gerrit.cloudera.org:8080/#/c/15108/7/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test File testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test: http://gerrit.cloudera.org:8080/#/c/15108/7/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test@403 PS7, Line 403: > Note that Impala EE tests do not need ORDER BY to make the results determin Done http://gerrit.cloudera.org:8080/#/c/15108/7/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/15108/7/tests/authorization/test_ranger.py@805 PS7, Line 805: policy_cnt += 1 > Can you also add a mask for a nested column? As we discussed in chat, it is Done -- To view, visit http://gerrit.cloudera.org:8080/15108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1cc5565c64c1a4a56445b8edde59b1168f387791 Gerrit-Change-Number: 15108 Gerrit-PatchSet: 8 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Mon, 03 Feb 2020 13:10:51 +0000 Gerrit-HasComments: Yes
