Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/15134 )
Change subject: IMPALA-9279: Update the Kudu version to include VARCHAR support ...................................................................... Patch Set 2: (2 comments) > > > Patch Set 2: > > > The verify job failed because kudu-3ba5ec5d0 (kudu-1.12.0-SNAPSHOT) > > has a new run-time dependency: libcurl.so.4 which is not > available > > in the ubuntu-16.04-configured jenkins worker label. I'm > discussing > > with laszlog the possibility of adding libcurls.so.4 to the > worker > > labe;. > > > > > > > If we decide to take this new Kudu version as a dependency, then > > the correct way to handle libcurl.so.4 as a new runtime > dependency > > is to add it to the list of packages we install in > > bin/bootstrap_system.sh. > > The worker image referenced above is only minimally preconfigured > > to allow fast startup times; Impala runtime/development time > > dependencies should be managed in the bootstrap scripts. > > > > Additionally, the dependency on libcurl.so.4 should be evaluated > > for all OS platforms we claim to have support for: e.g. a brief > > scan of this article[1] claims that running both libcurl.so.3 and > > libcurl.so.4 on Ubuntu 18.04 is at least non-trivial to set up. > > > > [1]: > > https://dev.to/jake/using-libcurl3-and-libcurl4-on-ubuntu-1804-bionic-184g, > > "Using libcurl3 and libcurl4 on Ubuntu 18.04 (Bionic)" > > In bin/bootstrap_system.sh, I don't see us installing curl for > ubuntu, but I see us installing it for centos. I would try adding > it and see if that helps. (We have curl installed in all the docker > images we use to build kudu for the native toolchain.) > > We can run a ubuntu-18.04-from-scratch job to see if it works. Installing curl on Ubuntu 16.04 installs libcurl-gnutls.so.4 but it doesn't install the required libcurl.so.4. "apt install libcurl3" on the other hand works for all supported Ubuntu releases, so I've added that to bin/bootstrap_system.sh. http://gerrit.cloudera.org:8080/#/c/15134/2/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/15134/2/bin/impala-config.sh@719 PS2, Line 719: export IMPALA_TOOLCHAIN_KUDU_MAVEN_REPOSITORY="file://${IMPALA_TOOLCHAIN}" > Since this is disabled, I think we can set it to an empty string. If that w Setting url to an empty string results in an error but I can set it to something like "file:///non/existing/repo" What do you think? http://gerrit.cloudera.org:8080/#/c/15134/2/bin/impala-config.sh@722 PS2, Line 722: export IMPALA_KUDU_VERSION="3ba5ec5d0" : export IMPALA_KUDU_JAVA_VERSION="1.12.0-SNAPSHOT" > One use case that we want to support is for someone to be able to override Done -- To view, visit http://gerrit.cloudera.org:8080/15134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iafe56342d43cb63e35c0bbb1b4a99327dda0a44a Gerrit-Change-Number: 15134 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Mon, 03 Feb 2020 14:49:40 +0000 Gerrit-HasComments: Yes
