Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15151 )
Change subject: IMPALA-9289: Fix flakiness in TestConcurrentKuduCreate ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15151/1/tests/custom_cluster/test_concurrent_kudu_create.py File tests/custom_cluster/test_concurrent_kudu_create.py: http://gerrit.cloudera.org:8080/#/c/15151/1/tests/custom_cluster/test_concurrent_kudu_create.py@a47 PS1, Line 47: > I am not very familiar with the usage of tls.client. Is it true that we do Replied this at line65. http://gerrit.cloudera.org:8080/#/c/15151/1/tests/custom_cluster/test_concurrent_kudu_create.py@51 PS1, Line 51: pool = ThreadPool(processes=3) > Just like to check whether or not my understanding is correct. The reason t Yes, we can reuse the threads and therefore reuse the client (connection) in the thread. http://gerrit.cloudera.org:8080/#/c/15151/1/tests/custom_cluster/test_concurrent_kudu_create.py@65 PS1, Line 65: pool > I looked at other usages of client and it seems that we don't need to expli Yes, when the threads are terminated, their connections are closed so the associated sessions are closed too. I verify these in impalad.INFO. By the way, since this is a custom cluster test, the cluster will be restarted after the test. So we don't need to be afraid of potential session leaks affecting other tests. -- To view, visit http://gerrit.cloudera.org:8080/15151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idefba98ecd65efbd47b1618291330795ef13b910 Gerrit-Change-Number: 15151 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Mon, 03 Feb 2020 22:56:07 +0000 Gerrit-HasComments: Yes
