Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 )
Change subject: WIP: Asynchronous code generation ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/15105/5/be/src/exec/hdfs-avro-scanner.cc File be/src/exec/hdfs-avro-scanner.cc: http://gerrit.cloudera.org:8080/#/c/15105/5/be/src/exec/hdfs-avro-scanner.cc@1149 PS5, Line 1149: /// return fn(this, max_tuples, pool, &data_block_, data_block_end_, tuple, tuple_row); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/15105/5/be/src/exec/hdfs-scanner.h File be/src/exec/hdfs-scanner.h: http://gerrit.cloudera.org:8080/#/c/15105/5/be/src/exec/hdfs-scanner.h@448 PS5, Line 448: using InterpretedRetT = decltype((This->*interpreted_fn)(std::forward<Args>(args)...)); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/15105/5/be/src/exec/hdfs-scanner.h@450 PS5, Line 450: "The return types of the codegen'd and interpreted functions must be the same."); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/15105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7cbfa7c6734dcf03641629429057d6a4194aa6b Gerrit-Change-Number: 15105 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 05 Feb 2020 13:18:18 +0000 Gerrit-HasComments: Yes
