David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15132 )
Change subject: IMPALA-3343: Make impala-shell compatible with python 3. ...................................................................... Patch Set 10: (3 comments) OK, this is really the last revision to get it ready for final review. I was so focused on getting the minicluster tests to pass that I neglected to check kerberized connections. minicluster tests are passing, and I've confirmed that I can connect to both a kerberized cluster, and LDAP-protected cluster over HTTP. http://gerrit.cloudera.org:8080/#/c/15132/9/shell/thrift_sasl.py File shell/thrift_sasl.py: http://gerrit.cloudera.org:8080/#/c/15132/9/shell/thrift_sasl.py@27 PS9, Line 27: > flake8: E501 line too long (97 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/15132/9/shell/thrift_sasl.py@62 PS9, Line 62: > flake8: E261 at least two spaces before inline comment Done http://gerrit.cloudera.org:8080/#/c/15132/9/shell/thrift_sasl.py@64 PS9, Line 64: > flake8: E261 at least two spaces before inline comment Done -- To view, visit http://gerrit.cloudera.org:8080/15132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb75e162bac0faeae3e12106c15da39cbfb8b462 Gerrit-Change-Number: 15132 Gerrit-PatchSet: 10 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 07 Feb 2020 20:51:46 +0000 Gerrit-HasComments: Yes
