Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15170
to look at the new patch set (#5).
Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache
implementation
......................................................................
IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation
In a previous change, the Kudu caching code from be/src/kudu/util was
copied to be/src/util/cache. This gets that code workable for Impala
and uses it for the DataCache.
This involves the following changes:
1. Fix up includes to point to Impala's cache implementation
2. Remove NVM Cache support and code (not used by Impala)
3. Remove CacheMetrics code (not used by Impala)
4. Move the cache code to the impala namespace
5. Modify cache-bench and cache-test to use Impala's backend
test infrastructure
6. Switch DataCache to use be/src/util/cache
These are only boilerplate changes. The cache implementation has not
meaningfully changed.
Testing:
- Ran core tests
- The modified version of Kudu's cache-test passes
- The modified version of Kudu's cache-bench runs successfully
Change-Id: I917f8352c9276373dd2761af986bf3487855271c
---
M .clang-tidy
M be/CMakeLists.txt
M be/src/runtime/io/data-cache.cc
M be/src/runtime/io/data-cache.h
M be/src/util/CMakeLists.txt
M be/src/util/cache/CMakeLists.txt
M be/src/util/cache/cache-bench.cc
M be/src/util/cache/cache-test.cc
M be/src/util/cache/cache.cc
M be/src/util/cache/cache.h
D be/src/util/cache/nvm_cache.cc
D be/src/util/cache/nvm_cache.h
M bin/rat_exclude_files.txt
13 files changed, 74 insertions(+), 949 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/15170/5
--
To view, visit http://gerrit.cloudera.org:8080/15170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I917f8352c9276373dd2761af986bf3487855271c
Gerrit-Change-Number: 15170
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
