Vihang Karajgaonkar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................


Patch Set 12:

(2 comments)

> > (1 comment)
 >
 > The error is: cannot found class PartitionExpressionForMetastore. I
 > add class one by one to keep pom files minimal, all including four
 > classed.

Ah I see. I think this can be fixed by setting metastore.expression.proxy to 
org.apache.hadoop.hive.metastore.DefaultPartitionExpressionProxy in the 
hive-site.xml.py if hive_major_version >=3 here: 
https://github.com/apache/impala/blob/master/fe/src/test/resources/hive-site.xml.py#L93

The PartitionExpressionProxy API is only usable by Hive since it uses some of 
its internal classes which are unavailable to non-hive applications. Refer 
https://cwiki.apache.org/confluence/display/Hive/AdminManual+Metastore+3.0+Administration
 standalone mode for more details.

http://gerrit.cloudera.org:8080/#/c/15057/12/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/12/fe/pom.xml@1065
PS12, Line 1065:           <scope>runtime</scope>
I would avoid making any changes to hive-2 profile since they seem unnecessary.


http://gerrit.cloudera.org:8080/#/c/15057/12/fe/pom.xml@1235
PS12, Line 1235:           <version>${hive.version}</version>
This dependency can be changed to a runtime scope here for hive-3 profile only 
since we don't want to depend on it for compilation.
<scope>runtime</scope>



--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 12
Gerrit-Owner: wangsheng <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: wangsheng <[email protected]>
Gerrit-Comment-Date: Mon, 10 Feb 2020 18:45:27 +0000
Gerrit-HasComments: Yes

Reply via email to