Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15186 )
Change subject: IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters ...................................................................... Patch Set 1: (1 comment) I actually filed IMPALA-9366 as a generic task to remove all embedded pointer references which include the use of CastPtrToLlvmPtr() to embed them http://gerrit.cloudera.org:8080/#/c/15186/1/be/src/exec/partitioned-hash-join-builder.cc File be/src/exec/partitioned-hash-join-builder.cc: http://gerrit.cloudera.org:8080/#/c/15186/1/be/src/exec/partitioned-hash-join-builder.cc@638 PS1, Line 638: FilterContext filter_ctxs[], TupleRow* build_row) noexcept { > DCHECK that filter_ctx is referring to the same array as filter_ctx_? Done -- To view, visit http://gerrit.cloudera.org:8080/15186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09037b5832b037536bde9324f7a2a10778511114 Gerrit-Change-Number: 15186 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 11 Feb 2020 21:21:58 +0000 Gerrit-HasComments: Yes
