Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15123 )
Change subject: IMPALA-7002: Throw AuthorizationException when user accesses non-existent table/database in CTE without required privileges. ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/15123/12/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/15123/12/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@606 PS12, Line 606: authorize("with t as (select nocol from functional.alltypes) select * from t") : .error(selectError("functional.alltypes")); : : // Select from non-existent column in CTE with required privileges : // for all existent columns : authorize("with t as (select nocol from functional.alltypes) select * from t") : .error(selectError("functional.alltypes"), onColumn("functional", "alltypes", : ALLTYPES_COLUMNS, TPrivilegeLevel.SELECT)); nit: you can merge these two like : authorize("with t as (select nocol from functional.alltypes) select * from t").error(selectError("functional.alltypes")).error(selectError("functional.alltypes"), onColumn("functional", "alltypes", ALLTYPES_COLUMNS, TPrivilegeLevel.SELECT)); -- To view, visit http://gerrit.cloudera.org:8080/15123 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia6b657a7147a136198a9a97a679c9131ee814577 Gerrit-Change-Number: 15123 Gerrit-PatchSet: 12 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 12 Feb 2020 22:07:09 +0000 Gerrit-HasComments: Yes
