Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/13806 )
Change subject: IMPALA-6663: Expose current DDL metrics on WebUI ...................................................................... Patch Set 13: Code-Review+1 (2 comments) Left a small nit, but lgtm. http://gerrit.cloudera.org:8080/#/c/13806/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/13806/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@427 PS8, Line 427: case DROP_FUNCTION: > It is possible that I misunderstood the concerns here, but I will try to an I see, I misunderstood something, thanks for clarifying. http://gerrit.cloudera.org:8080/#/c/13806/13/fe/src/test/java/org/apache/impala/catalog/monitor/CatalogFinalizeDmlCounterTest.java File fe/src/test/java/org/apache/impala/catalog/monitor/CatalogFinalizeDmlCounterTest.java: http://gerrit.cloudera.org:8080/#/c/13806/13/fe/src/test/java/org/apache/impala/catalog/monitor/CatalogFinalizeDmlCounterTest.java@34 PS13, Line 34: private final String TEST_UPDATE_SQL = "UPDATE table SET c3 = " : + "'test';"; nit: this string could be written without concatenation. -- To view, visit http://gerrit.cloudera.org:8080/13806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ed76f134bad6d3b3d4dce132365a53a01e9512a Gerrit-Change-Number: 13806 Gerrit-PatchSet: 13 Gerrit-Owner: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 13 Feb 2020 11:41:28 +0000 Gerrit-HasComments: Yes
