Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15217 )
Change subject: IMPALA-8909: Fix incorrectly omitting implicit cast in pre-insert sort ...................................................................... Patch Set 1: Code-Review+2 I think this is the right fix - it should ensure that the root type of the exprs doesn't get changed. There are some broader challenges with the whole implicit cast concept. -- To view, visit http://gerrit.cloudera.org:8080/15217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icca8ab1456a3b840a47833119c9d4fd31a1fff90 Gerrit-Change-Number: 15217 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 13 Feb 2020 18:40:20 +0000 Gerrit-HasComments: No
