Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15213 )
Change subject: IMPALA-9256: Refactor constraint information into a separate class. ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15213/3/fe/src/main/java/org/apache/impala/analysis/TableDef.java File fe/src/main/java/org/apache/impala/analysis/TableDef.java: http://gerrit.cloudera.org:8080/#/c/15213/3/fe/src/main/java/org/apache/impala/analysis/TableDef.java@520 PS3, Line 520: if (fk.getForeignKeyColNames().size() != fk.getPrimaryKeyColNames().size()){ Is it possible that these two are both 0? If so, should we throw AnalysisException as well? http://gerrit.cloudera.org:8080/#/c/15213/3/fe/src/main/java/org/apache/impala/analysis/TableDef.java@578 PS3, Line 578: nit: should be two spaces indention -- To view, visit http://gerrit.cloudera.org:8080/15213 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f1c441c24df84d2d0791ffe94dff60d039a3341 Gerrit-Change-Number: 15213 Gerrit-PatchSet: 3 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 15 Feb 2020 01:38:02 +0000 Gerrit-HasComments: Yes
