Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15222 )
Change subject: IMPALA-9385: Unix time conversion cleanup + ORC fix ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/15222/4/be/src/exprs/timezone_db.h File be/src/exprs/timezone_db.h: http://gerrit.cloudera.org:8080/#/c/15222/4/be/src/exprs/timezone_db.h@77 PS4, Line 77: // Note that in performance critical parts of the code it is recommended line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15222/4/be/src/exprs/timezone_db.h@79 PS4, Line 79: // TimestampValue functions have optimized path for it. line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/15222 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14e2a7e512ccd013d5d9fe480a5467ed4c46b76e Gerrit-Change-Number: 15222 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 17 Feb 2020 14:44:53 +0000 Gerrit-HasComments: Yes
