Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15154 )
Change subject: IMPALA-8712: Make ExecQueryFInstances async ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/15154/5/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/15154/5/be/src/runtime/coordinator-backend-state.cc@90 PS5, Line 90: exec_serialization_timer_ = PROFILE_ExecSerializationTimer.Instantiate(host_profile_); > Sure, I mean after thinking about it some more, I would probably prefer to Hadn't noticed "Backend startup latencies" before. So true, you could derive an estimate of the serialization time with the current metrics, however, I think still think it requires expert knowledge of how these runtime profile metrics are created. Most average Impala users wouldn't be able to figure this out on their own. Regardless, adding this is really only a nice to have, and not directly related to this patch. So happy with just pushing this out to a follow up JIRA. -- To view, visit http://gerrit.cloudera.org:8080/15154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33ec96e5885af094c294cd3a76c242995263ba32 Gerrit-Change-Number: 15154 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Fri, 21 Feb 2020 00:32:47 +0000 Gerrit-HasComments: Yes
