Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/15259 )
Change subject: IMPALA-4080: Moved codegen code from scan exec nodes to their plan nodes ...................................................................... Patch Set 1: (4 comments) I did a quick scan, I've just a few nits. http://gerrit.cloudera.org:8080/#/c/15259/1/be/src/exec/hdfs-avro-scanner.h File be/src/exec/hdfs-avro-scanner.h: http://gerrit.cloudera.org:8080/#/c/15259/1/be/src/exec/hdfs-avro-scanner.h@98 PS1, Line 98: static Status Codegen( Does dropping WARN_UNUSED_RESULT has a reason? The same happens in many other places. http://gerrit.cloudera.org:8080/#/c/15259/1/be/src/exec/hdfs-avro-scanner.h@211 PS1, Line 211: static Status CodegenDecodeAvroData(const HdfsScanPlanNode* node, RuntimeState* state, Same as line 98. http://gerrit.cloudera.org:8080/#/c/15259/1/be/src/exec/hdfs-avro-scanner.h@237 PS1, Line 237: * Why change this to a pointer? As far as I could see from the implementation, it cannot be null. http://gerrit.cloudera.org:8080/#/c/15259/1/be/src/runtime/query-state.h File be/src/runtime/query-state.h: http://gerrit.cloudera.org:8080/#/c/15259/1/be/src/runtime/query-state.h@249 PS1, Line 249: vector<const TPlanFragmentInstanceCtx*> GetTPlanFragmentInstanceCtxs( > Nit: return const & since they shouldn't be null I'm not sure you can use references in a container. -- To view, visit http://gerrit.cloudera.org:8080/15259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02c6183271b3731aa0d3cae2426be7269e462967 Gerrit-Change-Number: 15259 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 21 Feb 2020 14:43:22 +0000 Gerrit-HasComments: Yes
