Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15242 )
Change subject: IMPALA-9395: fix duplicate broadcast SetFilter() calls ...................................................................... IMPALA-9395: fix duplicate broadcast SetFilter() calls For broadcast join filters, we can get duplicate filters - one set from the coordinator and one set locally. The intent is that the first-arriving filter is used (it's exposed to consumers via SetFilter()) and the later filters are ignored. This should be guaranteed by checking HasFilter() in the same critical section as SetFilter(). I checked all code paths in runtime-filter-bank.cc that call SetFilter() for broadcast filters and fixed the single exception. Testing: I wasn't able to reproduce this issue locally. Ran runtime filter tests to check for regressions. Change-Id: I95d0620c4dbb5e4066702db48442cebee7389f5a Reviewed-on: http://gerrit.cloudera.org:8080/15242 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/runtime-filter-bank.cc M be/src/runtime/runtime-filter-bank.h 2 files changed, 19 insertions(+), 13 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I95d0620c4dbb5e4066702db48442cebee7389f5a Gerrit-Change-Number: 15242 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
