Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15228 )
Change subject: Convert dataload hdfs copy commands to LOAD DATA statements ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15228/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15228/2//COMMIT_MSG@44 PS2, Line 44: minutes speedup overall. > garbled? Fixed this up. http://gerrit.cloudera.org:8080/#/c/15228/2/testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test File testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test: http://gerrit.cloudera.org:8080/#/c/15228/2/testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test@487 PS2, Line 487: table: rows=unavailable size=482.93KB > was this required? I thought we ignored the file sizes in planner tests It will ignore differences in sizes, but it doesn't include size=unavailable right now. That is something we could change. Other things like row-size and cardinality use a much less restrictive regex and seem to include "unavailable". https://github.com/apache/impala/blob/master/fe/src/test/java/org/apache/impala/testutil/TestUtils.java#L71-L73 https://github.com/apache/impala/blob/master/fe/src/test/java/org/apache/impala/testutil/TestUtils.java#L172 -- To view, visit http://gerrit.cloudera.org:8080/15228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf17b85ff85618933716a80f1ccd6701b07f464c Gerrit-Change-Number: 15228 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 22 Feb 2020 00:18:49 +0000 Gerrit-HasComments: Yes
