Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15260 )
Change subject: IMPALA-9357: Fix race condition in alter_database event ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/15260/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15260/1//COMMIT_MSG@25 PS1, Line 25: the test in a loop for a long duration to make sure it doesn't fail. Can we reproduce the bug by keep altering the comment of a db? And even do that in multithreads? http://gerrit.cloudera.org:8080/#/c/15260/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/15260/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@851 PS1, Line 851: nit: 4 spaces indent -- To view, visit http://gerrit.cloudera.org:8080/15260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I472fd8a55740769ee5cdb84e48422a4ab39a8d1e Gerrit-Change-Number: 15260 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 24 Feb 2020 07:33:03 +0000 Gerrit-HasComments: Yes
