Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 )
Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations ...................................................................... Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/15179/7/be/src/util/cache/cache-internal.h File be/src/util/cache/cache-internal.h: http://gerrit.cloudera.org:8080/#/c/15179/7/be/src/util/cache/cache-internal.h@34 PS7, Line 34: HandleBase(uint8_t* kv_ptr, const Slice& key, int32_t hash, int val_len, int charge) { Might be useful to have a comment, eg. "kv_ptr points to memory allocated to fit..." http://gerrit.cloudera.org:8080/#/c/15179/7/be/src/util/cache/cache-internal.h@46 PS7, Line 46: formatting http://gerrit.cloudera.org:8080/#/c/15179/7/be/src/util/cache/cache-internal.h@215 PS7, Line 215: mem_tracker_ = kudu::MemTracker::FindOrCreateGlobalTracker( Do you know how, if at all, we integration this with our own mem tracking, eg. ExecEnv::process_mem_tracker or the /memz webui page? http://gerrit.cloudera.org:8080/#/c/15179/7/be/src/util/cache/cache.cc File be/src/util/cache/cache.cc: http://gerrit.cloudera.org:8080/#/c/15179/7/be/src/util/cache/cache.cc@a79 PS7, Line 79: I think this comment is still true and useful, wrt HandleBase::kv_data_ptr_? http://gerrit.cloudera.org:8080/#/c/15179/7/be/src/util/cache/cache.cc@a554 PS7, Line 554: This appears to have been dropped. Is it no longer the case? http://gerrit.cloudera.org:8080/#/c/15179/7/be/src/util/cache/cache.cc@a560 PS7, Line 560: I think this comment may also still be useful? -- To view, visit http://gerrit.cloudera.org:8080/15179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67294244a3e8a2812f1482fe786bf7f8e6ce054e Gerrit-Change-Number: 15179 Gerrit-PatchSet: 7 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Mon, 24 Feb 2020 18:56:42 +0000 Gerrit-HasComments: Yes
