Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15285 )
Change subject: IMPALA-4080 [part 4]: Moved code responsible for codegen from select and union's exec node to their plan node. ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15285/1/be/src/exec/union-node.h File be/src/exec/union-node.h: http://gerrit.cloudera.org:8080/#/c/15285/1/be/src/exec/union-node.h@61 PS1, Line 61: int first_materialized_child_idx_; Initialise to an invalid value? -- To view, visit http://gerrit.cloudera.org:8080/15285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0610b93b9a13da19e35151b231349c0ab16071d2 Gerrit-Change-Number: 15285 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2020 16:26:03 +0000 Gerrit-HasComments: Yes
