Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15263 )
Change subject: IMPALA-9369: Make createInsertEvents() async. ...................................................................... Patch Set 2: Thanks for researching CompletableFuture :) I added the shutdown for the thread. I changed the patch to run only the firing HMS API asynchronous. This should also prevent the issues of table lock being released. Regarding modifying the state, my understanding is that from Impala's perspective this async function does not change any state except logging in case of any exceptions. Please correct me if I'm wrong. -- To view, visit http://gerrit.cloudera.org:8080/15263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97802a5c03abc067fccf9e3a9d0047324626706e Gerrit-Change-Number: 15263 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 02 Mar 2020 01:53:47 +0000 Gerrit-HasComments: No
