Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15338 )
Change subject: IMPALA-9445: skip test_local_tz_conversion for hbase ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15338/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15338/2//COMMIT_MSG@10 PS2, Line 10: bit unfortunate I think that it doesn't add extra coverage to run this on S3, so it's ok to leave it this way. I added this test only to avoid the very specific bug of depending on flag use_local_tz_for_unix_timestamp_conversions when reading timestamps from different fileformats, as this bug could not be detected by tests that run with default flags. -- To view, visit http://gerrit.cloudera.org:8080/15338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fb603ebe0a5820d2eed0b6ec5dca2980fd5521d Gerrit-Change-Number: 15338 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 02 Mar 2020 21:31:32 +0000 Gerrit-HasComments: Yes
