Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15310 )
Change subject: IMPALA-9431 [DOCS] Update docs to reflect Deflate is supported for text files ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/15310/2/docs/topics/impala_txtfile.xml File docs/topics/impala_txtfile.xml: http://gerrit.cloudera.org:8080/#/c/15310/2/docs/topics/impala_txtfile.xml@263 PS2, Line 263: <codeph>.gz</codeph>, <codeph>.snappy</codeph>, or <codeph>.zst</codeph>, <codeph>.deflate</codeph>. typo: or should be before the last item in the list. nit: Also, if you could put these in alphabetical order that would be great. http://gerrit.cloudera.org:8080/#/c/15310/2/docs/topics/impala_txtfile.xml@658 PS2, Line 658: memory overhead is reduced for bzip-, deflate-, gzip-, and zstd-compressed text files. The nit: I think we should use bzip2- instead of bzip- http://gerrit.cloudera.org:8080/#/c/15310/2/docs/topics/impala_txtfile.xml@710 PS2, Line 710: 48 hdfs://127.0.0.1:8020/user/hive/warehouse/file_formats.db/csv_compressed/csv_compressed_deflate.csv.deflate Thanks for updating the size. For others reviewing this PR, I verified that these are correct. -- To view, visit http://gerrit.cloudera.org:8080/15310 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e1205e4e408f2c20fd8642cccd6c74e7ba9eb40 Gerrit-Change-Number: 15310 Gerrit-PatchSet: 2 Gerrit-Owner: Kristine Hahn <kh...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Mar 2020 23:01:12 +0000 Gerrit-HasComments: Yes
