Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15288 )
Change subject: IMPALA-6360: Don't show full query statement on Impala WebUI by default ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/15288/10/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/15288/10/be/src/service/impala-server.cc@151 PS10, Line 151: display nit: displayed http://gerrit.cloudera.org:8080/#/c/15288/10/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/15288/10/tests/webserver/test_web_pages.py@422 PS10, Line 422: enought nit: typo http://gerrit.cloudera.org:8080/#/c/15288/10/tests/webserver/test_web_pages.py@429 PS10, Line 429: contain nit: contains http://gerrit.cloudera.org:8080/#/c/15288/10/tests/webserver/test_web_pages.py@434 PS10, Line 434: stmt_response The name of this variable is misleading here as it's not storing the response anymore. -- To view, visit http://gerrit.cloudera.org:8080/15288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7109a0be5d1022b4f8d6e72441cf5dc1dc42605 Gerrit-Change-Number: 15288 Gerrit-PatchSet: 10 Gerrit-Owner: Adam Tamas <[email protected]> Gerrit-Reviewer: Adam Tamas <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Wed, 04 Mar 2020 08:12:27 +0000 Gerrit-HasComments: Yes
