Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15308 )
Change subject: IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled ...................................................................... Patch Set 2: (1 comment) Patch set 2 submitted. We say that remote runtime filter is enabled if it successfully received all filter updates from pending backends, regardless if there is an RPC failure later in publish phase. I try to avoid calling this flag "is_complete_" because this flag only applies to remote filter case. http://gerrit.cloudera.org:8080/#/c/15308/1/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/15308/1/be/src/runtime/coordinator-backend-state.cc@671 PS1, Line 671: state->get_publish_filter_done_cv().notify_one(); > Agree, I will move the flag right after the Disable() call in UpdateFilter( Done -- To view, visit http://gerrit.cloudera.org:8080/15308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82a5a776103abd0a6d73336bebc65e22b4e13fef Gerrit-Change-Number: 15308 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 04 Mar 2020 17:44:03 +0000 Gerrit-HasComments: Yes
