David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15219 )
Change subject: IMPALA-9384: Improve Impala shell usability by enabling live_progress in interactive mode ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15219/3/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/15219/3/shell/option_parser.py@307 PS3, Line 307: elif option == parser.get_option('--disable_live_progress'): > I think the reason I added this line is because we want to make the help te Ah, you're totally right. Sorry -- I read too quickly, and didn't notice that this is only about the default value shown in the help output. On the other hand, I actually think being able to call $ impala-shell --live_progress --disable_live_progress --live_progress or this, for that matter... $ impala-shell --verbose --quiet --verbose ...is a subtle bug, and we should raise a parser error in that case, because it's not clear what the intention is. -- To view, visit http://gerrit.cloudera.org:8080/15219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3765b775f663fa227e59728acffe4d5ea9a5e2d3 Gerrit-Change-Number: 15219 Gerrit-PatchSet: 3 Gerrit-Owner: Alice Fan <[email protected]> Gerrit-Reviewer: Alice Fan <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 04 Mar 2020 23:23:05 +0000 Gerrit-HasComments: Yes
