Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 )
Change subject: WIP: Asynchronous code generation ...................................................................... Patch Set 18: I would suggest just unnesting the typedef and putting it at the top of the file. Nested definitions cause a lot of problems like this, I think they're mostly not a good idea *unless* they're only used internally within the class that they're defined in. I originally used nested definitions fairly liberally myself but I changed my mind on this after trying to reorganise DiskIoMgr headers to reduce the number of header dependencies - it was impossible without unnesting all of the classes. -- To view, visit http://gerrit.cloudera.org:8080/15105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7cbfa7c6734dcf03641629429057d6a4194aa6b Gerrit-Change-Number: 15105 Gerrit-PatchSet: 18 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 05 Mar 2020 15:58:55 +0000 Gerrit-HasComments: No
